[bugfix] Fix access beyond IP layer bounds if packet stops right after it #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed potential out-of-bounds access and added test for the encountered special (invalid) IP packet scenario.
I'm also trying to capture an actual small
pcap
file on the host in question to get a sample for the E2E tests, but didn't happen again so far... 🙈Performance is actually slightly better (probably because the hint now is more accurate for everything that happens in the function):
Nice catch!
Closes #279