-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Global performance-optimization overhaul of micro-operations and rotation flow #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
fako1024
added
feature
New feature or request
performance
Performance / optimization related topics
observability
Telemetry sent from the tools
labels
Apr 4, 2024
els0r
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely love the PR / effort. Go for it.
Some nitpicks:
- have a look at never-nesting in some of the functions (see comments)
- constants for the used indices in
EPHash
Co-authored-by: Lennart Elsen <els0r@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
New feature or request
observability
Telemetry sent from the tools
performance
Performance / optimization related topics
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major steps undertaken:
Fundamental changes:
if-then-else
types.Counters
) and handed over as string (which is uses for compiler optimizations in map access anyway and can be copied to thehashmap
during rotation a little faster)MaybeRemains
andMaybeReverts
for direction detection (was a nice idea, but factually all rules determine the direction from the first observed packet, so the additional tracking / overhead is simply not required - but could be added later again should we ever come across more complex heuristics)Micro-optimizations:
EPHash
(both new IPv4 and IPv6 versions) to allow copying / transferring / reversing them with fewer operations (due to contiguous memory areas that can be copied in one go)Misc:
445/TCP
and8080/TCP
to list of common (destination) ports that are pre-aggegated (based on their abundance in productive environments) - Note: This will be on top of the posted benchmarks here and OSAG internal (didn't want to skew the measurements - reducing the cardinality obviously makes stuff faster) !! 😉Result summary:
Closes #284