[bugfix] Integrate improved three-point lock for capture routines and improve concurrency patterns #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…concurrency patterns
fako1024
added
bug
3 tasks
els0r
approved these changes
May 23, 2024
| status, err := mc.status() | ||
| if lErr := mc.capLock.Unlock(); lErr != nil { | ||
| logger := logging.FromContext(runCtx) | ||
| logger.Errorf("failed to release status call three-point lock: %s", err) |
There was a problem hiding this comment.
Nitpick: this is copy-pasta. Put into err messages.
| logger := logging.FromContext(runCtx) | ||
| logger.Errorf("failed to release status call three-point lock: %s", err) | ||
| if err := mc.close(); err != nil { | ||
| logger.Errorf("failed to close capture after failed three-point lock: %s", err) |
| @@ -62,6 +63,51 @@ func (t testMockSrcs) Wait() error { | |||
| return nil | |||
| } | |||
|
|
|||
| // func TestInterfaceChanges(t *testing.T) { | |||
There was a problem hiding this comment.
Out with it? Or do you still need it?
fako1024
deleted the
317-deadlock-in-three-point-capture-routine-lock-sporadic
branch
fako1024
restored the
317-deadlock-in-three-point-capture-routine-lock-sporadic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at fixing (or at least improving) the potential deadlocks. I still wasn't able to reproduce the issue to its full extend, but at least one of the observed crashes I confirmed to be addressed by this. The issue will remain open after merging this for further assessment.