[feature] Goquery: less verbose and frequent keep-alive messages #327
Conversation
| t.footerWriter.WriteEntry(queryStatsKey, "displayed top %s hits out of %s in %s", | ||
| hitsDisplayed, | ||
| hitsTotal, | ||
| textFormatter.Duration(result.Summary.Timings.QueryDuration), | ||
| ) | ||
| result.Query.PrintFooter(t.footerWriter) | ||
|
|
||
| if t.printQueryStats { |
There was a problem hiding this comment.
That's if you want them. Looks as follows:
packets packets bytes bytes
iface sip dip dport proto in out % in out %
eth7 10.236.33.234 10.236.130.23 443 TCP 24.00 M 34.21 M 51.27 2.48 GB 31.53 GB 50.57
... ... ... ...
47.24 M 66.30 M 5.55 GB 61.68 GB
Totals: 113.55 M 67.23 GB
Timespan : [2023-09-06 23:58:54, 2024-04-13 20:35:00] (219d20h36m0s)
Interface : 11 queried
Sorted by : accumulated data volume (sent and received)
Conditions : dport = 443
Query stats : displayed top 1 hits out of 23 in 1m0.517s
Bytes loaded : 0.00 B
Bytes decompressed : 100.19 MB
Blocks processed : 5.11 M
Blocks corrupted : 0.00
Directories processed : 2.22 k
Workloads : 72.00
There was a problem hiding this comment.
Something that keeps bothering me (nitpick, but just because I see it again): We format integers / counters as floats, even if they are zero or on the "base" unit like B or just a number (not only here, but also in the general table). IIRC there is some humanize method somewhere and could be slightly adjusted in a fly-by? 😉
There was a problem hiding this comment.
That bugs me too. I was about to adjust it already. Will see if I can do it non-invasively.
There was a problem hiding this comment.
Fixed: even allowed me to remove some code:
Timespan : [2023-09-06 23:58:54, 2024-04-13 20:35:00] (219d20h36m0s)
Interface : 11 queried
Sorted by : accumulated data volume (sent and received)
Conditions : dport = 443
Query stats : displayed top 1 hits out of 23 in 9.036s
Bytes loaded : 0 B
Bytes decompressed : 100.19 MB
Blocks processed : 5.11 M
Blocks corrupted : 0
Directories processed : 2.22 k
Workloads : 72
There was a problem hiding this comment.
Will do in separate issue to keep the changelog clean
| t.footerWriter.WriteEntry(queryStatsKey, "displayed top %s hits out of %s in %s", | ||
| hitsDisplayed, | ||
| hitsTotal, | ||
| textFormatter.Duration(result.Summary.Timings.QueryDuration), | ||
| ) | ||
| result.Query.PrintFooter(t.footerWriter) | ||
|
|
||
| if t.printQueryStats { |
There was a problem hiding this comment.
Something that keeps bothering me (nitpick, but just because I see it again): We format integers / counters as floats, even if they are zero or on the "base" unit like B or just a number (not only here, but also in the general table). IIRC there is some humanize method somewhere and could be slightly adjusted in a fly-by? 😉
els0r
changed the title
els0r
changed the title
els0r
changed the title
els0r
deleted the
326-goquery-provide-stats-updates-less-frequently-and-with-flow-map-aggregates
branch
Closes #326