[bugfix] Fix missing query route and DB path parsing in goQuery API #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fako1024
commented
Aug 14, 2024
| // New creates a new goprobe API server | ||
| func New(addr string, captureManager *capture.Manager, configMonitor *config.Monitor, opts ...server.Option) *Server { | ||
| func New(addr, dbPath string, captureManager *capture.Manager, configMonitor *config.Monitor, opts ...server.Option) *Server { |
There was a problem hiding this comment.
Made the path a required argument for the API as it is not optional and cannot be guessed properly (just because we fall back here to the default doesn't mean this has been done elsewhere in the same way).
fako1024
commented
Aug 14, 2024
| @@ -14,6 +14,19 @@ var queryTags = []string{"Query"} | |||
|
|
|||
| // RegisterQueryAPI registers all query related endpoints | |||
| func RegisterQueryAPI(a huma.API, caller string, querier query.Runner, middlewares huma.Middlewares) { | |||
| // query running | |||
| huma.Register(a, | |||
There was a problem hiding this comment.
This section exists below for the distributed query, but seems to have been forgotten here...
fako1024
commented
Aug 14, 2024
| @@ -14,7 +14,3 @@ go.work.sum | |||
| .db/ | |||
| tmp/ | |||
| bin/ | |||
| goProbe | |||
There was a problem hiding this comment.
These were triggering on the cmd/XXX subfolders, ignoring changes under them.
els0r
approved these changes
Aug 22, 2024
fako1024
deleted the
340-goprobe-query-api-missing-_query-endpoint-broken-config-file-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments in PR code for details.
Closes #340