[bugfix] Strip whitespace from args.Query when sanitizing it
#348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
els0r
deleted the
347-bugfix-make-sure-that-spaces-in-the-queryargsattributes-are-removed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where queries such as
"sip, dip,dport"wouldn't be evaluated only because of the whitespace in them.The implicit assumption was that this wouldn't happen if called from the command line (due to the arguments being evaluated as
[]string{..., "sip,", "dip,dport"}. For thejsoncase, this is very much a valid way of passing the arguments.Sanitization is applied both in goQuery (to local DB) and global-query.
Closes #347 .