Refactor proto actor runtime with snapshot support #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/modules/Elsa.ProtoActor/Configuration/ProtoActorFeature.cs # src/modules/Elsa.Workflows.Runtime/Services/IWorkflowInvoker.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the proto actor runtime implementation by removing the need to create and update workflow instance documents continuously.
Instead, workflow instances now purely live in-memory in the proto actor runtime as virtual actors aka grains.
Each workflow instance grain persists snapshots after every workflow execution. The snapshot persistence provider is pluggable and uses an in-memory provider by default.
We still need a way to persist a full/current view of workflow instances for e.g. dashboarding. But this aspect is now pluggable and can use different strategies. Examples are:
These export operations will happen asynchronously in the background, preventing them from hindering workflow execution throughput.