Make the timeout configurable for acquiring the DistributedLock in ContinueRunningWorkflows #4678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in a multi node environment, a running Workflow on one node can block the ResumeWorkflow Startup on another node.
This PR adds an additional configuration setting to be able to have a custom timeout for acquiring the DistributedLock in the ContinueRunningWorkflows Startup, which resumes all
running
oridling
Workflows.With this setting i can define a short Timeout like 5-10s before i stop acquiring the lock.
If i can not acquire the lock in a short timespan, i assume that the other node is running this workflow, and i can skip resuming this workflow.
This design would potentially leave 2 edgecases unhandled:
I choose the default timeout of 1h like before on the DistributedLockTimeout, to not break stuff, but maybe a default timeout of 5-10 seconds would be good.
see also: #4654