Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow cancellation #4813

Merged
merged 10 commits into from
Jan 23, 2024
Merged

Workflow cancellation #4813

merged 10 commits into from
Jan 23, 2024

Conversation

raymonddenhaan
Copy link
Contributor

Allows the cancellation of running and suspended workflows including any child activities.

Limitations:

  • This feature has not yet been implemented in the user interface
  • Dispatched child activities are not being cancelled

@raymonddenhaan
Copy link
Contributor Author

@dotnet-policy-service agree company="nexxbiz"

Copy link
Member

@sfmskywalker sfmskywalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR - thank you. You provided an elegant solution to cancelling both suspended and actively running workflows and activities, and you provided tests. In addition, I think that you increased the overall code quality 🔥

@sfmskywalker sfmskywalker merged commit c409414 into main Jan 23, 2024
1 of 2 checks passed
@sfmskywalker sfmskywalker deleted the feature/workflow-cancellation branch January 23, 2024 11:05
lahma pushed a commit to lahma/elsa-core that referenced this pull request Feb 2, 2024
* Removed duplicate entries

* Prevented workflows and activities from starting when the parent workflow is being cancelled

* Added cancellation to execution contexts

* Added store for workflow execution contexts

* Added cancellation to workflowRuntime

* Removed calling BookmarkPersistedHandler when persisting bookmarks.

* Added endpoint for bulk cancelling tasks

* Added tests for cancelling workflows

* Prevented cancelling the cancellation process since it could have unwanted effects

---------

Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants