-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow cancellation #4813
Merged
Merged
Workflow cancellation #4813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flow is being cancelled
@dotnet-policy-service agree company="nexxbiz" |
sfmskywalker
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR - thank you. You provided an elegant solution to cancelling both suspended and actively running workflows and activities, and you provided tests. In addition, I think that you increased the overall code quality 🔥
src/modules/Elsa.Workflows.Core/Contexts/WorkflowExecutionContext.Cancel.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Workflows.Runtime/Services/DefaultWorkflowRuntime.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Workflows.Runtime/Services/DefaultWorkflowRuntime.cs
Outdated
Show resolved
Hide resolved
lahma
pushed a commit
to lahma/elsa-core
that referenced
this pull request
Feb 2, 2024
* Removed duplicate entries * Prevented workflows and activities from starting when the parent workflow is being cancelled * Added cancellation to execution contexts * Added store for workflow execution contexts * Added cancellation to workflowRuntime * Removed calling BookmarkPersistedHandler when persisting bookmarks. * Added endpoint for bulk cancelling tasks * Added tests for cancelling workflows * Prevented cancelling the cancellation process since it could have unwanted effects --------- Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the cancellation of running and suspended workflows including any child activities.
Limitations: