Introduced messaging to running instances #4941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created classes and implemented the basic architecture for workflow cancellation. This includes command handlers, dispatchers, and consumers. However, the actual cancellation logic needs to be implemented later. Also, the Elsa solution file was cleaned up by deleting unnecessary entries.
…ub-sub # Conflicts: # Elsa.sln
…t have been processed
raymonddenhaan
requested review from
cristinamudura and
MariusVuscanNx
and removed request for
a team
sfmskywalker
requested changes
Feb 15, 2024
src/modules/Elsa.Hosting.Management/HostedServices/InstanceHeartbeatMonitorService.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Hosting.Management/HostedServices/InstanceHeartbeatService.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Hosting.Management/Notifications/InstanceDeactivated.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Hosting.Management/Options/HeartbeatSettings.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.MassTransit/Options/MassTransitWorkflowDispatcherOptions.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Workflows.Core/Contracts/IInstanceNameRetriever.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Workflows.Core/Contracts/IInstanceNameRetriever.cs
Outdated
Show resolved
Hide resolved
The names for properties related to instance heartbeats have been refactored, providing clearer semantics. 'InstanceHeartbeatRhythm' changed to 'Interval', and 'HeartbeatTimeoutPeriod' to 'Timeout'. This change impacts the property name in the HeartbeatOptions class and anywhere else it is referenced, including the appsettings.json file.
Major refactoring done across several files in the src/modules directory. This includes simplifying complex sections of code, removing extraneous comments, and improving the clarity of existing comments. In addition, method names and certain variable names were updated to more accurately reflect their function.
sfmskywalker
approved these changes
Feb 20, 2024
# Conflicts: # src/modules/Elsa.MassTransit.AzureServiceBus/Features/AzureServiceBusFeature.cs # src/modules/Elsa.MassTransit.RabbitMq/Features/RabbitMqServiceBusFeature.cs # src/modules/Elsa.MassTransit/Features/MassTransitWorkflowDispatcherFeature.cs # src/modules/Elsa.MassTransit/Implementations/MassTransitWorkflowDispatcher.cs # src/modules/Elsa.MassTransit/Services/MassTransitWorkflowCancellationDispatcher.cs # src/modules/Elsa.Workflows.Runtime/Responses/DispatchWorkflowDefinitionResponse.cs
sfmskywalker
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature will allow communication across nodes in a multi-node environment. Enabling features such as cancelling dispatched workflows and caching implementations.