Feature/cancel dispatched workflows #5136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfmskywalker
requested changes
Mar 27, 2024
| /// <summary> | ||
| /// Splits an enumerable into batches of a specified size. | ||
| /// </summary> | ||
| public static IEnumerable<IEnumerable<T>> ToBatches<T>(this IEnumerable<T> enumerable, int pageLimit) |
There was a problem hiding this comment.
Given the name of this method, it sounds like you could use the built-in Chunk extension.
| @@ -1,3 +1,4 @@ | |||
| using System.Diagnostics.CodeAnalysis; | |||
| } | ||
| } | ||
| catch (ServiceBusException e) when(e.Reason == ServiceBusFailureReason.MessagingEntityNotFound) | ||
| { |
There was a problem hiding this comment.
Let's add a logging statement here (perhaps of level "warning").
| @@ -28,6 +28,11 @@ public class WorkflowState | |||
| /// </summary> | |||
| public int DefinitionVersion { get; set; } | |||
|
|
|||
| /// <summary> | |||
| /// The ID of the workflow which dispatched this workflow. | |||
There was a problem hiding this comment.
The description does not seem to reflect the property's purpose.
| @@ -22,6 +22,11 @@ public class WorkflowInstance : Entity | |||
| /// The version of the workflow definition. | |||
| /// </summary> | |||
| public int Version { get; set; } | |||
|
|
|||
| /// <summary> | |||
| /// The ID of the workflow which dispatched this workflow. | |||
There was a problem hiding this comment.
The description does not seem to reflect the property's purpose.
| foreach (var workflowInstanceIdBatch in workflowInstanceIdBatches) | ||
| { | ||
| // Find child instances for the current workflow instance ID and cancel them. | ||
| // Do not check on status as their |
There was a problem hiding this comment.
This comment looks sounds like its incomplete.
| private async Task<int> CancelChildWorkflowInstances(IEnumerable<string> workflowInstanceIds, CancellationToken cancellationToken) | ||
| { | ||
| var tasks = new List<Task<int>>(); | ||
| var workflowInstanceIdBatches = workflowInstanceIds.ToBatches(50); |
There was a problem hiding this comment.
workflowInstanceIds.Chunk(50) should work too.
sfmskywalker
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures workflows that are dispatched gets cancelled.
There are 2 known issues:
Both issues will be picked up through issues #5031 and #4835 respectively
Closes #4177