Fix background activity completion #5882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added debug logging in `BookmarkResumer` and `StoreBookmarkQueue` to track workflow resumptions and queue additions. Updated `ICommitStateHandler` to include `WorkflowState` parameter and modified related implementations. Adjusted logging configuration in sample app and removed unused service import.
This change ensures that the `RootType` property is set to `AgentActivity` inside the `AgentActivityProvider`. It enhances the descriptor's metadata, enabling clearer classification and potentially improving integration with other components.
Modified RemoveBookmarksAsync to filter bookmarks by BookmarkIds rather than Hashes for improved accuracy. Updated filter creation logic to accommodate the new identifier field.
Add workflowState as an argument to commitStateHandler.CommitAsync. This ensures that the commitStateHandler has the necessary context to commit properly and maintains consistency in workflow state changes.
fanslead
pushed a commit
to fanslead/elsa-core
that referenced
this pull request
Aug 14, 2024
…core into feature/catchflow * 'feature/catchflow' of https://github.com/fanslead/elsa-core: (200 commits) [Fix] Replace "bundles" with "apps" in the content of README.md to align with current source code structure. (elsa-workflows#5885) Rename Model to ServiceProfile across the codebase. Add TenantId to workflow definition and skip multitenancy test Fix background activity completion (elsa-workflows#5882) Update persistence feature base classes to include self-type Refactor journal data access and improve byte[] handling (elsa-workflows#5878) Changed RegisterClassMap to TryRegisterClassMap on SerializedKeyValuePair classmap registration (elsa-workflows#5877) Add Orchard Core Integration + Agents Module (elsa-workflows#5871) Add customizable DB exception handlers Refactor workflow execution and pipeline handling Update elsa-v3-avatar.png Add new Elsa v3 avatar to design and update README Add MyEvent activity to Elsa services Add TODO Fix logger type Update ElsaStudioVersion to 3.2.0-rc4.473 Fix incorrect serializer reference Update pre-release version in GitHub Actions workflow Rework Workflow Context Feature (elsa-workflows#5861) Add engine exception handling middleware ...
|
@sfmskywalker Thank you for merging this fix. But is this already released? I think it did not make it into 3.2.0? |
|
Hi @JulienAmbos , this merge commit went into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed background activity completion by fixing a bug in the bookmark updater.
The bookmark updater was deleting too many bookmarks, preventing background activities from being resumed & completed.
This change is