Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-modifier to v3 #506

Merged
merged 2 commits into from
May 5, 2022
Merged

Conversation

BnitoBzh
Copy link
Contributor

@BnitoBzh BnitoBzh commented May 4, 2022

  • Global dependencies update, with ember-modifier to its version 3
  • Fix issue 328 by using requestAnimationFrame

Always on ember 3.28

The embroider optimized scenario fails, due to an issue with the field-guide addon

@elwayman02
Copy link
Owner

@BnitoBzh thank you for doing this! It's been on my todo list for quite some time but I've had an extremely busy 6 months or so. These changes all look great, we just need to get the tests passing in CI. The failures appear to be due to it using Node 12 (at least one of the packages you bumped requires Node 14), however I think it's fair to drop Node 12 support at this point. This will be a breaking release anyway, so can you try updating this package to drop Node 12?

My recommendation would be that we set the package.json to allow Node 14 and Node 16+, and then use Node 16 in CI if we can: https://github.com/elwayman02/ember-resize-modifier/blob/master/.github/workflows/ci.yml

@elwayman02 elwayman02 merged commit e0ee23f into elwayman02:master May 5, 2022
@elwayman02
Copy link
Owner

Thanks again! I'll try to get this released by next week at the latest.

@elwayman02 elwayman02 added internal breaking dependencies Pull requests that update a dependency file labels May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking dependencies Pull requests that update a dependency file internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants