-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2105 Parallax sample app does not look good in dark mode #2161
Conversation
Signed-off-by: Prince Sanchez <prince.sanchez@ibm.com>
@@ -21,6 +21,10 @@ | |||
// ---------------------------------------------------- | |||
.d3-node-group { | |||
|
|||
.d3-node-label{ | |||
color: black; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you were going to us a Carbon token here - right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested all of the text tokens
but the different shades of gray didn't seem to sit well with some of the lighter nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a keyword for the color ('black') is causing a build error. You can use the hex equivalent #000000 instead to allow the build to run.
BTW - You should really be making sure your PR builds OK and tests run successfully before putting it out for review.
Signed-off-by: Prince Sanchez <prince.sanchez@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Developer's Certificate of Origin 1.1