-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests to common parent folder to better code sharing #2160
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
343f8ad
to
17db61b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good - had a comment (3) related to Windows paths.
This will require that all IDE configurations for debugging specific modules be updated.
Please resolve the new conflicts.
4782e03
to
9c100b1
Compare
Given the recent commit, I suspect this instance was missed: https://github.com/elyra-ai/elyra/pull/2160/files#r717812729 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1578
Developer's Certificate of Origin 1.1