Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests to common parent folder to better code sharing #2160

Merged
merged 5 commits into from
Sep 30, 2021

Conversation

lresende
Copy link
Member

Fixes #1578

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Sep 20, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@lresende lresende added this to the 3.2.0 milestone Sep 20, 2021
@lresende lresende added the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Sep 20, 2021
@lresende lresende removed the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Sep 24, 2021
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good - had a comment (3) related to Windows paths.

This will require that all IDE configurations for debugging specific modules be updated.

Please resolve the new conflicts.

elyra/tests/metadata/test_utils.py Outdated Show resolved Hide resolved
elyra/tests/pipeline/kfp/test_component_parser_kfp.py Outdated Show resolved Hide resolved
@kevin-bates
Copy link
Member

Given the recent commit, I suspect this instance was missed: https://github.com/elyra-ai/elyra/pull/2160/files#r717812729

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lresende lresende merged this pull request into elyra-ai:master Sep 30, 2021
@lresende lresende deleted the dev-refactor-test branch September 30, 2021 17:20
lresende added a commit to lresende/elyra that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor elyra backend tests for code reuse support
2 participants