-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Elyra to Kfp v2 #3219
Open
harshad16
wants to merge
10
commits into
elyra-ai:main
Choose a base branch
from
opendatahub-io:kfpv2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate Elyra to Kfp v2 #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: bump version of kfp sdk
@@ -729,7 +704,7 @@ | |||
pipeline.pipeline_properties.get(pipeline_constants.COS_OBJECT_PREFIX), pipeline_instance_id | |||
) | |||
# - load the generic component definition template | |||
template_env = Environment(loader=PackageLoader("elyra", "templates/kubeflow/v1")) | |||
template_env = Environment(loader=PackageLoader("elyra", "templates/kubeflow/v2")) |
Check warning
Code scanning / CodeQL
Jinja2 templating with autoescape=False Medium
Using jinja2 templates with autoescape=False can potentially allow XSS attacks.
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Cap kfp version for avoiding protobuf version dependency
fix: update container properties according to kfpv2
fix: remove helper method to set image pull policy
fix: remove helper methods for adding toleration
Any update here? |
Working on it , will require some more time to finish this. |
Hi, can I ask when will this PR be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support for kfp v2.
This PR removed
kfp-tekton
from dependencies and allows only Argo to be used as controller runtime engine.Related-to:
#1930
#2918
How was this pull request tested?
To test this PR:
make clean install
at the root. This should install elyra-server and jupyter extensions.Developer's Certificate of Origin 1.1