Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable recursive library paths #840

Merged
merged 2 commits into from
Sep 5, 2024
Merged

feat: enable recursive library paths #840

merged 2 commits into from
Sep 5, 2024

Conversation

heraplem
Copy link

@heraplem heraplem commented Sep 5, 2024

Fixes #839.

@bdarcus
Copy link
Contributor

bdarcus commented Sep 5, 2024

Thanks for this!

The CI is complaining about some things. Beyond that, is this still in progress? The feature doesn't appear to actually be implemented here.

@heraplem
Copy link
Author

heraplem commented Sep 5, 2024

I believe it is implemented in 5084125? I'm using it in my own config, and it seems to work.

The CI byte-compiler errors should be fixed by 5a6c851. The linter errors seem to be coming from citar-org.el, which I didn't modify; not sure what to do about that.

@bdarcus bdarcus merged commit fb9a833 into emacs-citar:main Sep 5, 2024
5 of 6 checks passed
@bdarcus
Copy link
Contributor

bdarcus commented Sep 5, 2024

I squashed the two commits.

The linter errors seem to be coming from citar-org.el, which I didn't modify; not sure what to do about that.

We can handle that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow recursive library paths
2 participants
@heraplem @bdarcus