Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI is not parsing quoted args properly #128

Closed
Fuco1 opened this issue Feb 25, 2023 · 3 comments
Closed

CLI is not parsing quoted args properly #128

Fuco1 opened this issue Feb 25, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Fuco1
Copy link
Contributor

Fuco1 commented Feb 25, 2023

A quoted argument should be treated as a single token, it seems eask is splitting on space "naively"

The same command works with cask

eask exec buttercup -L . -L tests -p "should return bool if it is not surely non-eq to the other arg"

image
@jcs090218 jcs090218 mentioned this issue Feb 25, 2023
Merged
@jcs090218
Copy link
Member

jcs090218 commented Feb 25, 2023 •
edited
Loading

I've opened a fix in #129.

I was hoping there is an built-in solution, but I could not find one. :P

@jcs090218 jcs090218 added the bug Something isn't working label Feb 25, 2023
@jcs090218
Copy link
Member

It should be working now! Let me know if it works!

@Fuco1
Copy link
Contributor Author

Fuco1 commented Feb 27, 2023

Pulled the latest master and it works indeed. Thanks!

@Fuco1 Fuco1 closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fuco1 @jcs090218