Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(process): Workaround for arguments that contain whitespaces #129

Merged
merged 5 commits into from
Feb 26, 2023
Merged

fix(process): Workaround for arguments that contain whitespaces #129

merged 5 commits into from
Feb 26, 2023

Conversation

jcs090218
Copy link
Member

@jcs090218 jcs090218 commented Feb 25, 2023 •
edited
Loading

jcs090218
jcs090218 commented Feb 25, 2023
View reviewed changes
src/util.js
let result = '';
argv.forEach(function (element) {
// XXX: We wrap double quotes if the string contains spaces
if (/\s/g.test(element)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it from, https://stackoverflow.com/questions/1731190/check-if-a-string-has-white-space

@jcs090218 jcs090218 mentioned this pull request Feb 25, 2023
Closed
@jcs090218 jcs090218 added the bug Something isn't working label Feb 25, 2023
@jcs090218 jcs090218 merged commit fd84eee into master Feb 26, 2023
@jcs090218 jcs090218 deleted the fix/raw-args branch February 26, 2023 01:56
@jcs090218 jcs090218 mentioned this pull request Feb 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcs090218