PKGBUILD: avoid stripping the eask binary
#249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node puts scripts to some ELF sections, so we can't strip these.
Strictly speaking, judging by the offsets they seem to be put into
.dynstr section, but leaving that section unstripped doesn't make the
error
Pkg: Error reading from file
…go away. Unless someone is motivated to dig into the list of sections
to be put to `STRIP_BINARIES`, let's just disable it.
Fixes: emacs-eask#248
Hi-Angel
changed the title
eask binary
jcs090218
approved these changes
May 21, 2024
|
Thank you! |
|
And thank you too! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node puts scripts to some ELF sections, so we can't strip these. Strictly speaking, judging by the offsets they seem to be put into .dynstr section, but leaving that section unstripped doesn't make the error
…go away. Unless someone is motivated to dig into the list of sections to be put to
STRIP_BINARIES, let's just disable it.Fixes: #248