Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keybindings for with-editor #838

Merged
merged 1 commit into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions evil-collection.el
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,7 @@ See `evil-collection-init' and `evil-collection--modes-with-delayed-setup'."
wdired
wgrep
which-key
with-editor
woman
xref
xwidget
Expand Down
4 changes: 2 additions & 2 deletions modes/magit/evil-collection-magit.el
Original file line number Diff line number Diff line change
Expand Up @@ -495,8 +495,8 @@ denotes the original magit key for this command.")
("x" git-rebase-exec "exec = run command (the rest of the line) using shell")
("d" git-rebase-kill-line "drop = remove commit" "k")
("u" git-rebase-undo "undo last change")
(nil with-editor-finish "tell Git to make it happen")
(nil with-editor-cancel "tell Git that you changed your mind, i.e. abort")
("ZZ" with-editor-finish "tell Git to make it happen")
("ZQ" with-editor-cancel "tell Git that you changed your mind, i.e. abort")
("k" evil-previous-line "move point to previous line" "p")
("j" evil-next-line "move point to next line" "n")
("M-k" git-rebase-move-line-up "move the commit at point up" "\M-p")
Expand Down
45 changes: 45 additions & 0 deletions modes/with-editor/evil-collection-with-editor.el
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
;;; evil-collection-with-editor.el --- Bindings for `with-editor' -*- lexical-binding: t -*-

;; Copyright (C) 2024 Tianshu Wang

;; Author: Tianshu Wang <dev@wang.tianshu.me>
;; Maintainer: James Nguyen <james@jojojames.com>
;; Pierre Neidhardt <mail@ambrevar.xyz>
;; URL: https://github.com/emacs-evil/evil-collection
;; Version: 0.0.1
;; Package-Requires: ((emacs "26.3"))
;; Keywords: evil, emacs, tools

;; This program is free software; you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.

;; This program is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;; GNU General Public License for more details.

;; You should have received a copy of the GNU General Public License
;; along with this program. If not, see <http://www.gnu.org/licenses/>.

;;; Commentary:
;; Bindings for `with-editor'.

;;; Code:
(require 'evil-collection)
(require 'with-editor nil t)

(defvar with-editor-mode-map)

(defconst evil-collection-with-editor-maps '(with-editor-mode-map))

;;;###autoload
(defun evil-collection-with-editor-setup ()
"Set up `evil' bindings for `with-editor'."
(evil-collection-define-key 'normal 'with-editor-mode-map
"ZQ" 'with-editor-cancel
"ZZ" 'with-editor-finish))

(provide 'evil-collection-with-editor)
;;; evil-collection-with-editor.el ends here
Loading