Evil window selection should trigger ElDoc. #1044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. I can see this being annoying and why you'd want this behavior. Judging from eldoc's sources, such a thing is done for window commands already, so what you've added is fine, too. However, I'm not 100% happy with putting it after the definition of window commands, perhaps @TheBB what do you think? |
|
I agree, this is fine but it's more suitable for evil-integration. |
|
Alright. I moved it to the end of the integration file. |
|
Thanks, I squashed the commits for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
evil-define-motion, especially this line, it will bind the command being defined toeldoc-add-commandso that when this command is triggered, ElDoc will be triggered to redisplay documentation as well.But the window selection commands (such as
evil-window-up) are not "motion" and will not trigger ElDoc. So it's slightly annoying: after I switch to another window, and the cursor is now on top of something interesting, it will not show ElDoc documentation unless I move my cursor a bit.This PR makes sure that window selection will trigger ElDoc message as well.