ci: remove obsoleted if/when-let and shadowed dynamic variable and fix some byte-compile warnings

[kiennq]

This fixes:

• obsoleted if/when-let form
• shadowed dynamic variables in lsp-protocol (standard-output to be exact)
• And some byte-compile warnings

There're still quite a few byte-compile warnings left, but I would like to invite anyone who has spare cycles to chimp in to fix them together

[jcs090218]

Do you know why if-let and when-let is deprecated? I hope they don't since I have used those macros in many places. 😅

[kiennq]

Do you know why if-let and when-let is deprecated? I hope they don't since I have used those macros in many places. 😅

They switched to if/when-let* form

+++
** 'if-let' and 'when-let' are now obsolete.
Use 'if-let*', 'when-let*' and 'and-let*' instead.

This effectively obsoletes the old '(if-let (SYMBOL SOMETHING) ...)'
single binding syntax, which we'd kept only for backwards compatibility.

[jcs090218]

It's an improvement, so I'll approve it for the time being. Thanks for taking care of this! :)

[jcs090218]

It seems like this PR causes a lot of compile warnings. 🤔

In lsp-icons-all-the-icons-icon:
lsp-icons.el:87:2: Warning: docstring wider than 80 characters

Compiling file c:/Users/JenChieh/AppData/Roaming/.emacs.d/elpa/lsp-mode-20241119.828/lsp-ido.el at Wed Nov 20 14:06:45 2024
lsp-ido.el:78:2: Warning: docstring wider than 80 characters

...

In lsp-make-serenata-did-progress-indexing:
lsp-php.el:383:2: Warning: docstring wider than 80 characters

Compiling file c:/Users/JenChieh/AppData/Roaming/.emacs.d/elpa/lsp-mode-20241119.828/lsp-pls.el at Wed Nov 20 14:06:47 2024

Compiling file c:/Users/JenChieh/AppData/Roaming/.emacs.d/elpa/lsp-mode-20241119.828/lsp-prolog.el at Wed Nov 20 14:06:47 2024

Compiling file c:/Users/JenChieh/AppData/Roaming/.emacs.d/elpa/lsp-mode-20241119.828/lsp-protocol.el at Wed Nov 20 14:06:47 2024

In lsp-make-pwsh-script-region:
lsp-protocol.el:413:2: Warning: docstring wider than 80 characters

In lsp-make-omnisharp-ms-build-project:
lsp-protocol.el:415:2: Warning: docstring wider than 80 characters

In lsp-make-omnisharp-run-tests-in-class-request:
lsp-protocol.el:415:2: Warning: docstring wider than 80 characters

In lsp-make-omnisharp-dot-net-test-result:
lsp-protocol.el:415:2: Warning: docstring wider than 80 characters

In lsp-make-omnisharp-metadata-request:
lsp-protocol.el:415:2: Warning: docstring wider than 80 characters

In lsp-make-code-action-capabilities:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-completion-capabilities:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-completion-item:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-completion-item-capabilities:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-completion-options:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-diagnostic:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-document-symbol:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-document-symbol-capabilities:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-formatting-options:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-server-capabilities:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-signature-help-capabilities:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-signature-help-context:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-synchronization-capabilities:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-text-document-client-capabilities:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-text-document-sync-options:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-type-hierarchy-item:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-workspace-client-capabilities:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-workspace-edit-capabilities:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-workspace-file-operations:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-code-action:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-document-on-type-formatting-registration-options:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-initialize-params:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

In lsp-make-location-link:
lsp-protocol.el:603:2: Warning: docstring wider than 80 characters

[jcs090218]

FYI, I have reverted L116 and L117 in 73ad089 to prevent more compile warnings.

[kiennq]

This change so that we have the correct doc string for those function. Reverting them will make the docstring turn out to be wrong :(

Can we disable the docstring length warning instead? That would be hard to keep, especially with auto generated function from lsp-interface macro?

[jcs090218]

Ah, I got it. I think there is a variable to configure to turn off the 80-character limit. 🤔

Let me see what I can do about this! 👌

[jcs090218]

Probably not the best solution, but I've raised the 80-character limit to 1000. 🤔