Fix #314, activating php-mode moves point to last apostrophe #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a quick note, wouldn't it be better to only wrap the emacs 25 specific call of |
|
This PR may cause infinite loop. It is only php-mode function issue and propertize function should not be modified. I have sent PR #316. |
|
I have merged #316. Please check latest version. |
|
Great feedback, thanks for fixing up the solution! This bug was really annoying me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior was regressed by #307 because
re-search-forwardmoves point. I added asave-excursionaround that piece of code and a brief test.The test PHP file should probably contain more varied code to catch future regressions that might happen based on other characters, but for now I targeted this specific issue.
This is my first php-mode merge request so let me know if I can make it more friendly in any way.