change style initialization to interactive form php-set-style #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be able to select the php-mode code style with the remapped c-set-style key binding, to have a cleaner code base and reliable setting of default values over previously set values when changing the style. style variables tab-width, fill-column, require-final-newline and show-trailing-whitespace which are not present in all available php-mode code styles get their values set from the global default value on file eval time to the default "php" style. c-set-style was called twice before this change, now it is called once, so are the style mode hooks.
|
fyi https://travis-ci.org/calbrecht/php-mode/builds/287927594 merged into the non-failing branch, all is fine. |
|
@calbrecht Awesome job! I have made sure that this change works well in my environment. Thank you! |
zonuexe
approved these changes
Oct 14, 2017
|
Thank you @zonuexe :) |
zonuexe
added a commit
that referenced
this pull request
Sep 16, 2019
`eq` does not return `T` for comparison of equivalent string objects created separately. This bug was embedded #377 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be able to select the php-mode code style with the remapped
c-set-style key binding, to have a cleaner code base and reliable
setting of default values over previously set values when changing
the style.
style variables tab-width, fill-column, require-final-newline and
show-trailing-whitespace which are not present in all available
php-mode code styles get their values set from the global default
value on file eval time to the default "php" style.
c-set-style was called twice before this change, now it is called
once, so are the style mode hooks.