Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlighting of return types for abstract functions #461

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Fix highlighting of return types for abstract functions #461

merged 1 commit into from
Apr 23, 2018

Conversation

fabacino
Copy link
Contributor

If a class name is specified as the return type of an abstract function and positioned on another line than the function keyword, the class name was not highlighted at all.

Example:

abstract public function doSomething(
    string $type,
    int $number,
    bool $flag
): ?stdClass;
//  ^^^^^^^^

This commit highlights such class names as return types.

@fabacino
Fix highlighting of return types on different lines for abstract func…
06da1d7 
…tions

If a class name is specified as the return type of an abstract
function and positioned on another line than the `function` keyword,
the class name was not highlighted at all.

This commit highlights such class names as return types.
@zonuexe zonuexe merged commit e85d963 into emacs-php:master Apr 23, 2018
@zonuexe
Copy link
Member

zonuexe commented Apr 23, 2018

@fabacino Thanks!

@fabacino fabacino deleted the bugfix/fix-return-type-highlighting branch April 24, 2018 06:15
@zonuexe zonuexe mentioned this pull request May 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabacino @zonuexe