Replace uses of rx-form
#580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rx-form` is being removed in an upcoming version of Emacs and its rewrite of `rx`. Replacing it with `rx-to-string` is backwards and future compatible.
|
@cmack Thank you! |
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Oct 28, 2019
…pshot of Emacs PR: 241189 Submitted by: Yasuhiro KIMURA <yasu@utahime.org> (maintainer) Obtained from: emacs-php/php-mode#580 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@515840 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Oct 28, 2019
…pshot of Emacs PR: 241189 Submitted by: Yasuhiro KIMURA <yasu@utahime.org> (maintainer) Obtained from: emacs-php/php-mode#580
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this pull request
Oct 28, 2019
…pshot of Emacs PR: 241189 Submitted by: Yasuhiro KIMURA <yasu@utahime.org> (maintainer) Obtained from: emacs-php/php-mode#580 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@515840 35697150-7ecd-e111-bb59-0022644237b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upcoming versions of emacs have rewritten
rxand it appearsrx-formis no longer available (emacs-mirror/emacs@2ed7122)This PR will replace the two uses of
rx-formphp-create-regexp-for-method's use is replaced withrx-to-stringwhich works for supported Emacs before and after the commit referenced above.Use
abbreviate-file-nameinstead of the manual regex substitution. I'm not sure if I'm missing an edge case, but it appears this captures the same purposerx-formwas being used.Tests pass except for
php-mode-test-issue-186butmasteralso fails this test.