Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify over-indentation for PEAR style #777

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Modify over-indentation for PEAR style #777

merged 1 commit into from
Dec 17, 2023

Conversation

zonuexe
Copy link
Member

@zonuexe zonuexe commented Dec 17, 2023

No longer overindent it by default, since we don't see any mention in the coding style that it should hang ..

closes #227, #774 and #745, refs #229.

Note

If you have any feedback on PEAR style, please let us know in the discussion #776.

@@ -8,5 +8,5 @@

function my_func() {
return "a really long string with = inside " .
"some more text"; // ###php-mode-test### ((indent 49))
"some more text"; // ###php-mode-test### ((indent 8))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, this line was indented by PEAR style as shown below.

 function my_func() {
     return "a really long string with = inside " .
-                                                 "some more text";   // ###php-mode-test### ((indent 49))
+        "some more text";   // ###php-mode-test### ((indent 8))
 
 }

@zonuexe zonuexe merged commit a1781e2 into master Dec 17, 2023
14 of 15 checks passed
@zonuexe zonuexe deleted the modify-pear-style branch December 17, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return with multi-line strings indents strangely
1 participant