Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating getters doesn't work - or documentation needed #141

Open
rileyrg opened this issue Jan 8, 2020 · 4 comments
Open

creating getters doesn't work - or documentation needed #141

rileyrg opened this issue Jan 8, 2020 · 4 comments
Labels
behind from upstream bug Something isn't working

Comments

@rileyrg
Copy link

rileyrg commented Jan 8, 2020

When I have my cursor on a member variable and select "properties/accesor(a)" from the transient command or using php-generate-accessors I get:

phpactor--action-input-parameters: Keyword argument :multi not one of (:default :label :choices :type)
helm-M-x-execute-command: Keyword argument :multi not one of (:default :label :choices :type)

Screenshot from 2020-01-08 21-34-03

@zonuexe
Copy link
Member

zonuexe commented Jan 9, 2020

@rileyrg Thank you for reporting. I will investigate this issue tonight.

@zonuexe zonuexe added bug Something isn't working behind from upstream labels Jan 9, 2020
@rileyrg
Copy link
Author

rileyrg commented Jan 9, 2020

Thank you. I also added one re inserting namespaces but maybe it's a documentation thing as auto namespsce insertion at completion would have been raised before.

@rileyrg
Copy link
Author

rileyrg commented Jan 9, 2020

I pulled latest from melpa. nice , better but alas not working with helm. I can see the attributes but not actually action them. Hitting tab shows only the "f1 sole action".

Screenshot from 2020-01-09 23-23-08

turning off helm mode, I could get them completed but only one at a time and it wsa a tad confusing but that might be my setup - it allowed me to complete one member data then hit enter, then I had a blank prompt and hit enter again and then the accessor appeared in the code. BTW is the PHP standard for getters not to use get prefix?

@jjnilton
Copy link

Having a similar issue. It does work if the point is on the method, but doesn't work if it isn't, when I'm prompted to select a property.

Another thing is that if you have many properties, you got to select one by one and generate for each of them. It would be good if it generated all the accessors in the constructor at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behind from upstream bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants