Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: improve and unify function regexp #28

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

masicn
Copy link
Contributor

@masicn masicn commented Aug 8, 2024

Far from complete but reasonable amount of function syntax added.
Partial(since matching still occurs twice) unification solves signature-name search discrepancies.

@psibi
Copy link
Member

psibi commented Aug 8, 2024

Thanks for adding tests! Is this ready to merge since you have mentioned in the PR description that it's "far from complete"? These days I use treesit-beginning-of-defun for a similar use case.

@masicn
Copy link
Contributor Author

masicn commented Aug 9, 2024

Thanks for adding tests! Is this ready to merge since you have mentioned in the PR description that it's "far from complete"? These days I use treesit-beginning-of-defun for a similar use case.

The commit is fully functional and safe enough.
Regexp is incomplete but it is an improvement to previous version.

Treesiter seems like proper solution though, thanks for pointing out, I have been using old customization without it.

@psibi psibi merged commit 6ae74ee into emacs-rustic:main Aug 9, 2024
4 checks passed
@psibi
Copy link
Member

psibi commented Aug 9, 2024

Cool, thanks! Yeah, I have completely switched to treesitter now and I find it more reliable. Details here, if you want to switch: https://github.com/emacs-rustic/rustic?tab=readme-ov-file#tree-sitter

@masicn
Copy link
Contributor Author

masicn commented Aug 9, 2024

Cool, thanks! Yeah, I have completely switched to treesitter now and I find it more reliable. Details here, if you want to switch: https://github.com/emacs-rustic/rustic?tab=readme-ov-file#tree-sitter

Thank you for the merge and the instruction!

@masicn masicn deleted the cargo_fn_regexp branch August 9, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants