add a test for simple tsx #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josteink
reviewed
Nov 21, 2019
Dockerfile
Outdated
|
|
||
| RUN mkdir -p /home/typescript.el | ||
| COPY . /home/typescript.el | ||
| WORKDIR /home/typescript.el |
There was a problem hiding this comment.
Super-minor nitpick: If we're running the tests as root anyway, it seems a bit strange to create a "user"-folder in /home for our content. How about just /typescript-mode ?
|
Thanks for following up on my constant nagging for tests 😄 I only have one tiny nitpick. Consider it a suggestion, but not a merge-stopper in any way. If you don't think it's worthwhile, you can just go ahead and merge 👍 |
|
LGTM. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a missing test for #119.
It also includes a
Dockerfileand some instructions that can ease testing.Currently, the case provided in the test is
<div>test</div>anddivis not treated as a generic.However, a case with multiple tags on a line like
<div>test <span>me</span></div>would indeed highlight thespanas a generic type. Still open to solutions for this, although I personally just recommend web-mode for this