Prevent backspace parsing in replace-match #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only literal replacement is intended in
helm-ag--abbreviate-file-name
call toreplace-match
, so prevent backspace parsing by by passing LITERAL as true.E.g. if rg is used as helm-ag-base-command, it can output backslashes in its search results for binary files, so an error or unintended replacing behavior could occur.
Reproduction:
(setq helm-ag-base-command "rg --smart-case --no-heading --color=never --line-number --max-columns=150")
I opened git-gutter.el and git-gutter.elc, then used
helm-do-ag-buffers
to search for "git-gutter:linum-get-overlay" (mostly by accident), and the following error popped up (sorry for overlong backtrace):