Update config VALID_ARCHS for 64-bit Watch #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EdSancha could you merge this? This change is now necessary for anyone who wants to use Cleanroomlogger in a WatchOS extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cupertino has introduced a 64-bit S4 chip in the Apple Watch Series 4. Therefore, frameworks must be build targeting a new
arm64_32ARCH.Since CleanroomLogger enumerates
VALID_ARCHs in the project.xcconfig, this will need to be updated when a new processor architecture is introduced in a shipping product, as has happened recently. This PR updates the config accordingly.