Workaround for #2951 (extended timers were not actually usable) #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing as apparently I should do this only against main/HEAD, with the chiptool PAC changes included. Will try again another time when we've been able to migrate our code to use that stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if I'm creating this the right way, but the list of changes is correct. (Apologies if the trivial tab -> space changes are undesirable.)
The changes were tested against nrf52840 and work fine. I reviewed the other chips and confirmed that all with "extended" in any impl_timer!() now reference timer3, while the others reference timer0 (which is as they should).
Would be happy to see someone conceive of a cleaner or more obvious way to do this.