Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added metadata for miscellaneous models #1557

Merged
merged 9 commits into from
Dec 9, 2024
Merged

fix: Added metadata for miscellaneous models #1557

merged 9 commits into from
Dec 9, 2024

Conversation

x-tabdeveloping
Copy link
Collaborator

I made a script to generate metadata for models from HF Hub, and added metadata for models in the keep category on this issue #1515

@x-tabdeveloping
Copy link
Collaborator Author

Oops, made a silly blunder

@x-tabdeveloping
Copy link
Collaborator Author

Let me know if I need to run this for more models @Samoed @KennethEnevoldsen

Samoed
Samoed approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@Samoed Samoed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

scripts/generate_metadata.py Show resolved Hide resolved
isaac-chung
isaac-chung reviewed Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@isaac-chung isaac-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One major point about adapted_from to track finetunes.

mteb/models/misc_models.py Outdated Show resolved Hide resolved
scripts/generate_metadata.py Outdated Show resolved Hide resolved
mteb/models/misc_models.py Outdated Show resolved Hide resolved
KennethEnevoldsen
KennethEnevoldsen approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much new to add here - looks good outside of existing comments

@KennethEnevoldsen KennethEnevoldsen merged commit ce8c175 into main Dec 9, 2024
10 checks passed
@KennethEnevoldsen KennethEnevoldsen deleted the misc_models branch December 9, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaac-chung isaac-chung isaac-chung left review comments

@Samoed Samoed Samoed approved these changes

@KennethEnevoldsen KennethEnevoldsen KennethEnevoldsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@x-tabdeveloping @KennethEnevoldsen @Samoed @isaac-chung