Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix for #177. Previously, DRPES was selected based on the presence of the
RANK
environment variable. This led to issues for us during training with pytorch lightning.In this PR, we allow passing a keyword argument
parallel_retrieval
toMTEB.run
, which is further processed byAbsRetrieval.evaluate
andBeIRTask.load_data
to toggle the selection of DRES/DRPES. As a consequence, we also need to pass all kwargs ofMTEB.run
totask.load_data
. I am not sure whether this could possibly lead to problems in other parts of MTEB.