-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify retrieval #233
Simplify retrieval #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Globally, everything is good. I just left a comment about a test and a function call.
I've also added some datasets revision IDs, I guess you'll change them if you update the datasets.
Co-authored-by: Imene Kerboua <33312980+imenelydiaker@users.noreply.github.com>
Co-authored-by: Imene Kerboua <33312980+imenelydiaker@users.noreply.github.com>
@NouamaneTazi @loicmagne @tomaarsen Any thoughts? 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, great work!
beir
dependency - This makes installation easier due to less dependenciesI tested with komninos that all English Retrieval results for the datasets changed remain the same. It would be great if all of you could take a look at the PR, as this is the biggest change to MTEB since release.
I also tested to make sure the BeIR-PL tasks & Korean Retrieval tasks still work (cc @kwojtasi @taeminlee)