fix: Added sizes to the metadata #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allow for automatic metadata generations
Co-authored-by: Niklas Muennighoff <n.muennighoff@gmail.com>
mteb/abstasks/TaskMetadata.py
Outdated
| @@ -144,3 +146,6 @@ class TaskMetadata(BaseModel): | |||
|
|
|||
| text_creation: TEXT_CREATION_METHOD | None | |||
| bibtex_citation: str | None | |||
|
|
|||
| n_samples: dict[str, int] | |||
There was a problem hiding this comment.
Maybe we should specify these as dict[SPLIT_TYPE, int]? This can be something as simple as a type-alias, but makes it semantically clearer.
There was a problem hiding this comment.
Might also be nice to provide a little utility that gets this info, and document the utility here.
There was a problem hiding this comment.
it would be possible to check it using the eval_splits attr.
…nto add-size-to-meta
|
@MartinBernstorff it seems like we generally agree on this PR. I have left a comment unresolved as I am not entirely sure what you mean, but we can add it, in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allow for automatic metadata table generations