-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PawsX eval splits #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run one of the smaller models on this just to check that it works without issue?
Looks good! Agree with Kenneth. As a meta-question, maybe it's possible to check if the splits exist in the dataset without downloading it? Might be worth it if we get more errors like this. |
Yep was thinking about adding it to the test that checks if a dataset + revision id exists |
As I understand there is no API for this (at least documented), but you could probably do something like:
It only download metadata I believe:
Might be a way to generalize the existing tests. |
@imenelydiaker this test already exists (based on a recent pr) |
Yep I used |
So you just need to download the dataset in streaming mode to not store it locally and check the keys of the dataset object? Looks like a good alternative 🤔 |
Should I merge the fix and we'll open another PR for the test? |
Yeah, I'll give it a stab today 👍 |
Fix for issue #309. Eval splits didn't have the correct name.