New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging when the revision is None #329

Merged

KennethEnevoldsen merged 1 commit into embeddings-benchmark:main from Shopify:better-missing-revision-log

Apr 9, 2024

Contributor

gariepyalex commented Apr 8, 2024

This small PR fixes the logging for the missing dataset revision:

Use the current logger instead of the root logger
Adds the path of the dataset to the log. Previously, let's say you have in your code base many datasets with missing revision, it would simply log the message a few times at import time without telling you which datasets are problematic.


          Improve logging when the revision is None

53261f2

gariepyalex closed this

gariepyalex reopened this

KennethEnevoldsen approved these changes

View reviewed changes

KennethEnevoldsen merged commit 404587b into embeddings-benchmark:main

6 of 10 checks passed

Contributor

KennethEnevoldsen commented Apr 9, 2024

Thanks @gariepyalex

MartinBernstorff pushed a commit that referenced this pull request


          fix: Improve logging when the revision is None (#329)

89339e5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet