Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: octane upgrade v3.0.2...v3.16.1 #14

Merged
merged 5 commits into from
Jul 14, 2020
Merged

chore: octane upgrade v3.0.2...v3.16.1 #14

merged 5 commits into from
Jul 14, 2020

Conversation

rajasegar
Copy link
Member

@rajasegar rajasegar commented Apr 21, 2020 •
edited
Loading

  1. Fixed didTransition deprecations
  2. Add index controller for action
  3. Fixed lint errors for curly component syntax
  4. Used ember-cli-document-title-northm instead of ember-cli-document-title due to the prevailing issues
  5. Updated the README with new Octane syntax

Fixes #12 , #11

KamiKillertO
KamiKillertO approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@KamiKillertO KamiKillertO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👍

@tansongyang
Copy link
Contributor

tansongyang commented Jul 14, 2020 •
edited
Loading

@KamiKillertO Can this be merged so we can get a new release cut?

@KamiKillertO KamiKillertO merged commit a3dc40d into ember-a11y:master Jul 14, 2020
This was referenced Aug 25, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamiKillertO KamiKillertO KamiKillertO approved these changes

@sivakumar-kailasam sivakumar-kailasam Awaiting requested review from sivakumar-kailasam

@Robdel12 Robdel12 Awaiting requested review from Robdel12

@MelSumner MelSumner Awaiting requested review from MelSumner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

didTransition deprecated in 3.6.0
3 participants
@rajasegar @tansongyang @KamiKillertO