Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getWithDefault deprecation warning #35

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Fix getWithDefault deprecation warning #35

merged 1 commit into from
Mar 24, 2021

Conversation

tansongyang
Copy link
Contributor

This has been deprecated since Ember 3.21 and generates troublesome deprecation warnings.

@rwjblue rwjblue added the bug label Mar 24, 2021
@rwjblue rwjblue merged commit c0eb948 into ember-a11y:master Mar 24, 2021
@rwjblue
Copy link
Member

rwjblue commented Mar 24, 2021

Thanks @tansongyang!

@adc-mhaugen
Copy link

Are there plans to publish a release with this fix in it?

@adc-mhaugen
Copy link

How can I get this fix into my project @rwjblue? Unless I'm mistaken (certainly possible) there hasn't been a release with this fix?

@Robdel12
Copy link
Member

Since Ember Addons aren't precompiled prior to release, you can use the branch directly in your package.json ("a11y-announcer": "ember-a11y/a11y-announcer#master)

@adc-mhaugen
Copy link

Perfect, thanks @Robdel12!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants