Cancel timer for Ember.run.later in initializer.
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't the optimal fix: that's still to come, in the form of moving this out of an initializer and into `app/router.js` instead. However, this is a backwards-compatible stopgap which resolves a number of test failures which can arise if there are any bad interactions with other `Router` reopening or extension.
|
Nice! Thanks for the PR. I'm going to go ahead and merge since master fails on the same builds. |
Robdel12
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't the optimal fix: that's still to come, in the form of moving this out of an initializer and into
app/router.jsinstead. However, this is a backwards-compatible stopgap which resolves a number of test failures which can arise if there are any bad interactions with otherRouterreopening or extension.