Skip to content

Commit

Permalink
Pin ember-qunit to 5.0.0.
Browse files Browse the repository at this point in the history
ember-qunit@5.1.0 introduces a new axe-core failure:

```
Error: The page should have no accessibility violations. Violations:
[moderate]: Ensure that scrollable region has keyboard access
Violated 1 time. Offending nodes are:
<div id="ember-testing-container" style="visibility: visible; position:
relative;">
```

This gets CI passing again (the floating dependencies tests at least),
we will have to unpin as soon as possible but this should unblock other
bug fixes.
  • Loading branch information
rwjblue committed Feb 4, 2021
1 parent be7394c commit 34e0899
Show file tree
Hide file tree
Showing 2 changed files with 1,492 additions and 440 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"devDependencies": {
"@ember/jquery": "^1.1.0",
"@ember/optional-features": "^2.0.0",
"@ember/test-helpers": "^2.0.0",
"@ember/test-helpers": "^2.1.0",
"@glimmer/component": "^1.0.1",
"@glimmer/tracking": "^1.0.1",
"@types/ember": "^3.16.0",
Expand All @@ -70,7 +70,7 @@
"ember-export-application-global": "^2.0.1",
"ember-load-initializers": "^2.1.1",
"ember-maybe-import-regenerator": "^0.1.6",
"ember-qunit": "^5.0.0-beta.4",
"ember-qunit": "5.0.0",
"ember-radio-button": "^2.0.1",
"ember-resolver": "^8.0.2",
"ember-sinon": "^5.0.0",
Expand All @@ -89,7 +89,7 @@
"node-fetch": "^2.6.0",
"npm-run-all": "^4.1.5",
"prettier": "^2.0.5",
"qunit": "^2.11.0",
"qunit": "^2.14.0",
"release-it": "^14.0.0",
"release-it-lerna-changelog": "^3.0.0",
"sass": "^1.26.10",
Expand Down
Loading

0 comments on commit 34e0899

Please sign in to comment.