Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move component templates into app/components to resolve ember-beta errors. #567

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

deanmarano
Copy link
Contributor

@deanmarano deanmarano commented Nov 7, 2024

The issues in the ember-beta errors were due to changes in ember-resolver - it seems that loading components from the app/templates/components directory may have changed. Anyway, moving these components into the app/components directory fixed the lookup issues. This also fixed the ember-canary tests 🎉 .

@deanmarano deanmarano changed the title Move component templates into app/components. Move component templates into app/components to resolve ember-beta errors. Nov 7, 2024
@deanmarano deanmarano marked this pull request as ready for review November 7, 2024 21:05
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Copy link

@josephdsumner josephdsumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@MelSumner MelSumner merged commit 914134a into ember-a11y:main Nov 7, 2024
12 of 14 checks passed
@deanmarano deanmarano deleted the deanmarano/ember-beta-tests branch November 7, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants