Fix for ember-bootstrap v5.1 #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was throwing with `Assertion Failed: <PowerSelect> requires an `@onChange` function` as the components still referred to properties on `this` that don't exist anymore since ember-bootstrap/ember-bootstrap#1772. See failing [CI](https://github.com/kaliber5/ember-bootstrap-power-select/runs/6518834502?check_suite_focus=true#step:5:312)
|
@jelhan Fyi. I'll merge right away once CI passes, as I'm blocked on this. |
|
Thanks a lot for taking care of this one! Seems as if the test coverage is very low if it hasn't been catched in CI. 😞 |
It has, see the link in my first comment! It was just that e-b 5.1 introduced "breaking" (breaking for our "privileged addons that still have to extend from components, not breaking for anyone not extending) changes, which we already fixed for the other form-integration addons, but not yet here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was throwing with
Assertion Failed: <PowerSelect> requires an `@onChange` functionas the components still referred to properties onthisthat don't exist anymore since ember-bootstrap/ember-bootstrap#1772. See failing CI