Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use prefix as key name for revisions list #28

Closed
lukemelia opened this issue Sep 13, 2015 · 1 comment · Fixed by #32
Closed

Don't use prefix as key name for revisions list #28

lukemelia opened this issue Sep 13, 2015 · 1 comment · Fixed by #32

Comments

@lukemelia
Copy link
Contributor

It's confusing that the plugin uses the prefix as the key name for the revisions list. One expects a "prefix" to be before something. Let's change it to prefix + ":revisions"
@ghedamat
Copy link
Contributor

@achambers let us know what you think and if you wanna tackle this or if should I

I'll probably have a bit of time this week

ghedamat added a commit to ghedamat/ember-cli-deploy-redis that referenced this issue Sep 15, 2015
@ghedamat
store revision list in keyPrefix:revisions
91b656c 
fix ember-cli-deploy#28
@ghedamat ghedamat mentioned this issue Sep 15, 2015
Merged
ghedamat added a commit to ghedamat/ember-cli-deploy-redis that referenced this issue Sep 15, 2015
@ghedamat
store revision list in keyPrefix:revisions
9c7ddc8 
fix ember-cli-deploy#28
ghedamat added a commit to ghedamat/ember-cli-deploy-redis that referenced this issue Sep 15, 2015
@ghedamat
store revision list in keyPrefix:revisions
f82ede2 
fix ember-cli-deploy#28
ghedamat added a commit to ghedamat/ember-cli-deploy-redis that referenced this issue Sep 15, 2015
@ghedamat
store revision list in keyPrefix:revisions
47f409e 
fix ember-cli-deploy#28
ghedamat added a commit to ghedamat/ember-cli-deploy-redis that referenced this issue Sep 16, 2015
@ghedamat
store revision list in keyPrefix:revisions
3563b16 
fix ember-cli-deploy#28
ghedamat added a commit to ghedamat/ember-cli-deploy-redis that referenced this issue Sep 16, 2015
@ghedamat
store revision list in keyPrefix:revisions
1999ef8 
fix ember-cli-deploy#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

store revision list in keyPrefix:revisions ghedamat/ember-cli-deploy-redis
2 participants
@lukemelia @ghedamat