Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional dependencies to install instructions #57

Merged

Conversation

tribou
Copy link
Contributor

@tribou tribou commented Mar 22, 2016

I ran into an issue where my deployed revisions were not being listed. Fortunately, I happened across the ember-cli-deploy-display-revisions repo which fixed the issue; and I thought it would help others if all the dependencies needed for the basic deployment commands used by ember-cli-deploy-redis were listed in the README.

@achambers
Copy link
Member

Hi @tribou. Thanks so much for this. We've had some discussion around this and agree that it's useful info for new users. However, I think it's more appropriate in a section of it's own along the same lines as Activation.

The revisions (and activation) aren't required for using this plugin and therefore they don't really belong in the Quickstart section. That section is more for "these are the basic things you need to do to get up and running with this plugin". Instead, it feels like the revision info is better placed in it's own section.

Are you happy to make the relevant changes?

Thanks again for your input and suggesting this. Will merge the PR when it's ready.

@ghedamat
Copy link
Contributor

@tribou friendly ping :)

thanks again for this in the meantime!

@tribou tribou force-pushed the update-dependency-instructions branch from ac2c95d to 0624736 Compare May 25, 2016 01:33
@tribou
Copy link
Contributor Author

tribou commented May 25, 2016

Sorry for the delay on this!

@ghedamat ghedamat merged commit adfc579 into ember-cli-deploy:master Jun 4, 2016
@ghedamat
Copy link
Contributor

ghedamat commented Jun 4, 2016

thanks @tribou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants