-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip Heroku-style usernames from config url #58
Strip Heroku-style usernames from config url #58
Conversation
@lukemelia Thoughts here? |
}, | ||
|
||
_stripUsernameFromConfigUrl: function(configUrl) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, can you remove this?
@acorncom thanks for this, LGTM aside from the tiny comment just catching up on the issue here, basically we always need to specify username separately for that to work then? /cc @achambers @lukemelia |
@ghedamat Re: always needing to specify the username, from what I've been seeing it looks like the underlying At this point, I'm not sure if we want to merge this PR or work on fixing the upstream library (assuming they're willing to do it). But I'm not a huge fan of using non-spec compliant URLs ;-) Thoughts? |
9905edb
to
7e814cf
Compare
@ghedamat Spacing issue fixed too ;-) |
I've been lurking on this issue for awhile, and I would vote for attempting to fix the upstream library. EDIT: Of course, this is easy for me to say when I'm inventing work for other people. |
thanks @acorncom and sorry for the delay! |
@lukemelia maybe this is worth a |
@ghedamat agreed. |
Fixes #36