Fix readConfig bug #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayrawat
reviewed
Nov 22, 2016
| @@ -48,7 +48,7 @@ | |||
| "chalk": "^1.0.0", | |||
| "core-object": "^1.1.0", | |||
| "ember-cli-babel": "^5.0.0", | |||
| "ember-cli-deploy-plugin": "^0.2.1", | |||
| "ember-cli-deploy-plugin": "^0.2.9", | |||
There was a problem hiding this comment.
I've been bitten by loose versioning multiple times now. I'm not sure but isn't it better to use a strict version number here. Its ok not to also, perhaps the pros out weigh the cons. Just wanted to pick your brains.
|
@akshayrawat it js its pros and cons. We're generally very careful about ensuring we don't release breaking changes on minor versions however, we made a mistake this time that slipped through the net. In general though, the loose versioning should be fine here because we control both libs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64
This PR will use the new
pluginHelper.readConfigfunction to access config values of this plugin asthis.readConfigis no longer a valid function in a config property function.